Changed response wait time from 10 000 to 120 000 #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation specifies that the wait response timer could be as high as 120 000ms. When USOCL was called that the response time was higher than the previously set time of 10 000ms the MKRNB 1500 freezes.
|
|
per1234
added
type: imperfection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation specifies that the wait response timer could be as high as 120 000ms for the USOCL AT command. When USOCL was called and the response time was higher than the previously set time of 10 000ms the MKRNB 1500 freezes.
The changes were done to the NBClient.cpp's MODEM.waitForResponse. This fixed the issue of the MKRNB 1500 freezing while issuing the USOCL command in some cases.
There are more instances of MODEM.waitForResponse in other files, but it is unknown to me if these are calling the USOCL command.