Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.9.0 does not build on the Arduino 101 and Due #51

Closed
sandeepmistry opened this issue Apr 4, 2016 · 3 comments
Closed

v0.9.0 does not build on the Arduino 101 and Due #51

sandeepmistry opened this issue Apr 4, 2016 · 3 comments

Comments

@sandeepmistry
Copy link
Contributor

/Users/smistry/Documents/Arduino/libraries/WiFi101/src/WiFiMdnsResponder.cpp: In member function ‘bool WiFiMDNSResponder::parseRequest()’:
/Users/smistry/Documents/Arduino/libraries/WiFi101/src/WiFiMdnsResponder.cpp:152:61: error: ‘memcmp_P’ was not declared in this scope
     if (memcmp_P(request, expectedRequestHeader, HEADER_SIZE) == 0 &&            // request header match
                                                             ^
/Users/smistry/Documents/Arduino/libraries/WiFi101/src/WiFiMdnsResponder.cpp:154:72: error: ‘strncasecmp’ was not declared in this scope
         strncasecmp(name.c_str(), (char*)requestName, requestNameLength) == 0 && // name match
  1. The Arduino 101 does not provide memcmp_P in avr/pgmspace.h

  2. There is no strncasecmp method.

The AVR and SAMD cores build fine, however SAM core also experiences 1).

@facchinm any thoughts on how to proceed with this? This breakage was introduced in #47.

@facchinm
Copy link
Contributor

facchinm commented Apr 5, 2016

I believe that porting SAMD's avr/pgmspace.h to SAM and Curie will be the best long term solution 👍

@sandeepmistry
Copy link
Contributor Author

@sandeepmistry sandeepmistry changed the title v0.9.0 does not build on the Arduino 101 v0.9.0 does not build on the Arduino 101 and Due Apr 5, 2016
@sandeepmistry
Copy link
Contributor Author

The upstream changes have been merged and released (1.0.6 for the 101 core, 1.6.8 for SAM core).

Travis CI build is also now passing for the 101 and SAM.

cc/ @akash73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants