Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setPins API to override default WINC1500 pins #58

Merged
merged 1 commit into from
Jul 13, 2016

Conversation

sandeepmistry
Copy link
Contributor

A proposal to resolve #57.

I've added a WiFiClass::setPins(int8_t cs, int8_t irq, int8_t rst, int8_t en) API. This API must be called before any other WiFi APIs to take effect.

It currently uses 4 bytes more RAM, I've opted to store the pins as int8_t to save a few bytes of RAM on AVR. No issues changing to using int if that would be better.

Here's a size comparison ConnectWithWPA example sketch (sizes in bytes):

Board Before After Difference
Uno 21,470 21,528 58
Zero 19,820 19,916 96

cc/ @ladyada @cmaglie @facchinm

@trlafleur
Copy link

Yes, please add this to master branch soon...

Thanks

@sandeepmistry
Copy link
Contributor Author

Hi @trlafleur,

Have you had a chance to try this change out? If yes, please let us know how your testing went and which hardware you were using.

@trlafleur
Copy link

did a test with a Feather M0 board with a WINC1500, looks to work just
fine....

On Mon, Jul 11, 2016 at 2:46 PM, Sandeep Mistry notifications@github.com
wrote:

Hi @trlafleur https://github.com/trlafleur,

Have you had a chance to try this change out? If yes, please let us know
how your testing went and which hardware you were using.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#58 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AEXCKxxbuIzvK8-FZTacmuCzLBAPmOckks5qUrmagaJpZM4IEq7X
.

~~ _/) ~~~~ _/) ~~~~ _/) ~~~~ _/) ~~

Tom Lafleur

@sandeepmistry
Copy link
Contributor Author

@trlafleur thank you for testing and providing feedback.

@ladyada could you or someone else from @adafruit try this out and provide feedback before we merge?

@ladyada
Copy link

ladyada commented Jul 12, 2016

yep looks good to me!

@q2dg
Copy link

q2dg commented Aug 14, 2016

Ep! Don't forget add this new method to web's doc api reference (https://www.arduino.cc/en/Reference/WiFi101), please

@sandeepmistry sandeepmistry added To be documented and removed status: waiting for information More information must be provided before work can proceed labels Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WiFi101 should probably have user-config GPIO
6 participants