WiFiServer: check previous received client socket for data before querying a new one #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeepmistry
force-pushed
the
issue-52-fix
branch
from
3d75dee
to
939702e
Compare
Rocketct
approved these changes
Mar 27, 2019
|
See #87 |
ocrdu
added a commit
to ocrdu/WiFiNINA
that referenced
this pull request
Apr 26, 2021
|
This ill-conceived fix (to make one single example work that shouldn't have been programmed as it is in the first place) was made 4 years ago now, and has caused many problems when using multiple servers/sockets. Some of these problems were reported as issues, but somehow these issues have been ignored for years. This fix introduces a bug, plain and simple. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #52.