Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accent and Tab's ERROR #5277

Closed
danilodene opened this issue Aug 21, 2016 · 10 comments
Closed

Accent and Tab's ERROR #5277

danilodene opened this issue Aug 21, 2016 · 10 comments

Comments

@danilodene
Copy link

In the version 1.6.10 and 1.6.11 folder that has accent the IDE doesn't recognition TAB's

Error: functionXXX was not declared in this scope

@matthijskooijman
Copy link
Collaborator

Could you provide a complete (but minimal) example showing this problem? A sketch in zipfile is probably easiest, or just including the code in a comment (using the ``` code block markdown syntax around the code)

@danilodene
Copy link
Author

Sorry, I uploaded the video demonstrating the problem: https://www.youtube.com/watch?v=AMB4zOs6bRs&feature=youtu.be

@oqibidipo
Copy link

Seems to be the same problem as in #5216.

@dlabun
Copy link

dlabun commented Aug 23, 2016

It's the same issue, non-ASCII characters don't work in the IDE. The IDE throws error messages when you try to open / save files from the IDE with non-ASCII characters but it doesn't give you any useful errors during compiling. The only real fix to this would be enable full Unicode support.

@facchinm
Copy link
Member

The problem is due to https://github.com/arduino/arduino-builder/pull/156/files#diff-8f49a7d3dafee03fdad8aeee774529afR426
The ParseCppString function doesn't take into account the fact that a character could be a multibyte rune.
Ugly solution here, needs to be refactored/understood well but it works (the code was borrowed from https://github.com/golang/go/blob/master/src/net/mail/message.go)

@matthijskooijman

@dlabun
Copy link

dlabun commented Aug 26, 2016

@facchinm Until a full solution can be implement could an error message be added in? At least it could explain the issue to users.

@facchinm
Copy link
Member

@dlabun , it should be solved in the next few days, then it will be merged in nightly build so no need to add strings to explain something that is going to be fixed soon 😉

facchinm added a commit to facchinm/arduino-builder that referenced this issue Aug 29, 2016
Implementation borrowed from net/mail package (message.go)
Solves arduino/Arduino#5277
facchinm added a commit to facchinm/arduino-builder that referenced this issue Aug 29, 2016
Implementation borrowed from net/mail package (message.go)
Solves arduino/Arduino#5277
@facchinm
Copy link
Member

@dlabun , in the meantime you could test this PR arduino/arduino-builder#178 (comment)

Once you download the linked zip, replace the arduino-builder executable you can find in the IDE installation folder with the provided one

@oqibidipo
Copy link

oqibidipo commented Aug 29, 2016

My example from 5216 compiles without errors, also with a directory name like ‹smiley-face›‹lion-face›‹thunder-and-rain›‹snowman›.

@dlabun
Copy link

dlabun commented Aug 29, 2016

@facchinm Will do, should have results back this evening. I am going to test with Korean characters as well so #5216 can closed as well.

facchinm added a commit to facchinm/arduino-builder that referenced this issue Sep 12, 2016
Implementation borrowed from net/mail package (message.go)
Solves arduino/Arduino#5277

Signed-off-by: Martino Facchin <m.facchin@arduino.cc>
cmaglie added a commit to cmaglie/arduino-builder that referenced this issue Nov 23, 2016
Fix arduino/Arduino#5277

Signed-off-by: Cristian Maglie <c.maglie@arduino.cc>
@cmaglie cmaglie added this to the Release 1.6.14 milestone Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants