Boards Menu: add hint if core lives in sketchbook

[facchinm]

All Submissions:

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

For core development the recommended methods is to clone the core repo in $sketchbook/hardware. Before 9b48e8d these cores were listed after all Board Manager cores; now they are interleaved and quite difficult to spot immediately.
This patch adds the (sketchbook) label to cores living in sketchbook, using getAbsolutePath so symlinked cores can be spotted too).

[matthijskooijman]

Sounds like a good change. I've been modifying the platform.txt of these cores to change the label here, doing this automatically would be even better.

But I'm wondering if (sketchbook) is clear to users? I suspect a lot of users do not actually know the term sketchbook. People developing cores likely will, but there might also be people that have just followed some tutorial to install a core into their sketchbook and have no idea.

One alternative that springs to mind would be (manually installed) (as opposed to installed through board manager), but I'm not sure if that's really better (does not help finding the core files if needed).

Or how about (from sketchbook) (or (in sketchbook) or (installed in sketchbook))? That might make it clearer that this refers to the location of the core?

[facchinm]

(in sketchbook) sounds good, I'm amending the commit 😉

[matthijskooijman]

Hm, one more caveat: This now actually checks whether the absolute path is inside the sketchbook, but in my setup all my git checkouts live elsewhere and are symlinked into the sketchbook, so none of them show the (sketchbook) addition...

Would it make sense to, instead of looking at the path, keep a flag (or maybe a "source" field of "install dir/package dir/sketchbook") for each platform that is set when the platforms are loaded?

[facchinm]

Mine too are symlinked but I can see the label (they didn't show if I replace getAbsolutePath with getCanonicalPath in the subfolder check ). One alternative idea is to show the path (or a substring) if the sources are not in Arduino15 folder, which is unlikely to contain symlinks

[matthijskooijman]

Mine too are symlinked but I can see the label (they didn't show if I replace getAbsolutePath with getCanonicalPath in the subfolder check ).

Oh, good point. Let me doublecheck my setup and get back to you :-)

[ArduinoBot]

✅ Build completed.

Please test this code using one of the following:

⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-10007-BUILD-949-linux32.tar.xz
⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-10007-BUILD-949-linux64.tar.xz
⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-10007-BUILD-949-windows.zip
⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-10007-BUILD-949-macosx.zip
⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-10007-BUILD-949-linuxarm.tar.xz

ℹ️ The linuxarm build is still experimental and may not be always available.