Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Find in reference' will work even if no text has been selected. #112

Merged
merged 6 commits into from Aug 23, 2012

Conversation

s17t
Copy link

@s17t s17t commented Aug 19, 2012

No description provided.

@ghost ghost assigned damellis Aug 20, 2012
@damellis
Copy link
Contributor

Thanks for doing this. It seems like I wasn't clear in the behavior I wanted, though. If there's no text selected, the "find in reference" command should show the reference page for the string / token containing the text cursor. This looks like it will just show the main reference homepage, which isn't as useful. Can you update this to figure out the token that contains the text cursor and look up its page in the reference?

Also, I'm not a big fan of making other changes to the code in the course of fixing individual issues (e.g. things like the additional ignore or the new defaultIfEmpty function and ObjectUtils file). If possible, I'd prefer to make other changes separately and/or avoid them (especially, e.g. avoiding making new functions if they're only used in one place).

Let me know if you have any questions.

@s17t
Copy link
Author

s17t commented Aug 23, 2012

My bad. I didn't asked clarification before pull request.

@damellis damellis merged commit 36b643d into arduino:master Aug 23, 2012
@damellis
Copy link
Contributor

Thanks! I merged this request (after deleting the import of objectutils so it would compile).

One last thing to fix: the "find-in-reference" menu item is disabled in the right-click popup menu unless you've selected text. I opened an issue for this: http://code.google.com/p/arduino/issues/detail?id=1014

Can you fix that too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants