-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stack buffer overflow in String::getBytes() test #193
Conversation
Use string concatenation instead of creating a list.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #193 +/- ##
=======================================
Coverage 95.77% 95.77%
=======================================
Files 13 13
Lines 970 970
=======================================
Hits 929 929
Misses 41 41 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks for catching this @tttapa
@tttapa care to send another PR adding |
I appreciate the offer of bragging rights :) but I'm afraid I don't have the time right now. |
Hi @tttapa ☕ 👋 I've created a feature request for arduino/cpp-test-action. Once the action incorporates that feature we could just use the action twice in our unit-test.yml, to once run with valgrind and once without it (but with sanitizing enabled). What do you think? |
[String-getBytes-02]
test.CMAKE_{C,CXX}_FLAGS
variable intest/CMakeLists.txt
(string concatenation instead of list concatenation).This was caught by the GCC sanitizers. It might be a good idea to run the tests with
-fsanitize=address,undefined
in the CI (in addition to Valgrind) to catch these kinds of bugs early.