-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
properly initialized and checked Ethernet init callback (fix #890) #897
Conversation
@@ -5,7 +5,10 @@ | |||
int arduino::EthernetClass::begin(uint8_t *mac, unsigned long timeout, unsigned long responseTimeout) { | |||
if (eth_if == nullptr) { | |||
//Q: What is the callback for? | |||
_initializerCallback(); | |||
//A: To call a specific function on your system before any initialization is performed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
@manchoz are you aware of this callback being used somewhere? |
isn't already impossible to use the
|
@pennam, I could be wrong, but here is my understanding: |
@maidnl i was thinking if it makes any sense to keep the
|
Let's go ahead and remove it. I don't see any use case for this feature. |
👍 let's go for #900 |
superseded by #901 |
fix for potential null pointer access / _initializerCallback not initialized #890
This PR properly initializes _initializerCallback function pointer and checks for its validity before to call it