Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSU support for OTA on SaraU210 module #534

Merged
merged 5 commits into from
Jun 30, 2020
Merged

Conversation

Rocketct
Copy link
Contributor

Added API for write and read from sara module to retrive file during OTA's
procedure

cc:/ @manchoz

Copy link
Member

@facchinm facchinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it better to include GSMFileUtils in MKRGSM library and keep the 2nd stage BL cleaner? I'd also use another name (SSU 😄 ? ) for the library to avoid confusion since every OTA medium has its own subclass

@Rocketct
Copy link
Contributor Author

ok i'll revome from SFU and implement SSU 😃

@Rocketct Rocketct force-pushed the GSMOTA branch 2 times, most recently from 4f7fac4 to 0c9b178 Compare June 23, 2020 12:36
@Rocketct
Copy link
Contributor Author

done, are missing only the examples i will add when will be available and after merge, (and remove the white space added in ->boot/binary)

@Rocketct Rocketct requested a review from facchinm June 23, 2020 12:40
Copy link
Member

@facchinm facchinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect now :)

Added new core librares to manage Sara flash support, by useing new MKRGSM's  API
to write and read from sara module for retrive file during OTA's
procedure
@Rocketct Rocketct changed the title SFU support for OTA on SaraU210 module SSU support for OTA on SaraU210 module Jun 23, 2020
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Rocketct 👋
I think you can safely delete the SSU_LoadBinary example since this is used for the SFU and has nothing to do with the SSU. If there is a way how to upload a binary to the Sara-U210 via an Arduino sketch you could add that as an example sketch.
Cheers, Alex

@manchoz
Copy link
Contributor

manchoz commented Jun 24, 2020

@aentinger @Rocketct

I have updated also the examples here https://github.com/manchoz/ArduinoCore-samd/tree/manchoz_test_ssu/libraries/SSU/examples.

There are also a few minor changes to SSUBoot.ino because I have refactored GSMFileUtils::begin().

manchoz and others added 2 commits June 25, 2020 10:46
Co-authored-by: Riccardo Rizzo <37290960+Rocketct@users.noreply.github.com>
@Rocketct
Copy link
Contributor Author

Rocketct commented Jun 25, 2020

@manchoz @aentinger @facchinm added the examples I think that should be fine now

Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I wish there would be a rename functionality though ... but I've understood there is none?

@manchoz
Copy link
Contributor

manchoz commented Jun 25, 2020

@aentinger

LGTM 👍 I wish there would be a rename functionality though ... but I've understood there is none?

You are right; there is no rename functionality, unfortunately.

An alternative implementation would be appending the OTA header (or just the CRC) to the end of the file and check for its presence in SSUBoot.ino. WDYT?

@fabltd
Copy link

fabltd commented Jun 25, 2020 via email

@manchoz
Copy link
Contributor

manchoz commented Jun 25, 2020

Hi @fabltd,
You can find an example of how to do it manually here SSU_LoadBinary.ino.

A full example with HTTP download will be published in the coming days.

@fabltd
Copy link

fabltd commented Jun 25, 2020 via email

@manchoz
Copy link
Contributor

manchoz commented Jun 25, 2020

@fabltd here, alongside the other SSU examples. I will notify you when ready.

@aentinger
Copy link
Contributor

Hi @manchoz and @Rocketct 👋 Is this PR complete and tested? If so please let me know because I shall merge it in then.

@manchoz
Copy link
Contributor

manchoz commented Jun 30, 2020

@aentinger, yes, both complete and tested even by a third party.

@manchoz
Copy link
Contributor

manchoz commented Jun 30, 2020

@fabltd, SSU_HttpOta.ino will be merged soon.

Please, read the usage notes carefully.

@aentinger aentinger merged commit 44d354b into arduino:master Jun 30, 2020
@fabltd
Copy link

fabltd commented Jun 30, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants