Skip to content

Commit

Permalink
ContainerFindIncludes: Add some temporary variables
Browse files Browse the repository at this point in the history
This slightly cleans up a function call.

Signed-off-by: Matthijs Kooijman <matthijs@stdin.nl>
  • Loading branch information
matthijskooijman authored and cmaglie committed Jan 10, 2018
1 parent fc9a824 commit cfc4fd0
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion container_find_includes.go
Expand Up @@ -292,6 +292,8 @@ func writeCache(cache *includeCache, path string) error {

func findIncludesUntilDone(ctx *types.Context, cache *includeCache, sourceFile types.SourceFile) error {
sourcePath := sourceFile.SourcePath(ctx)
depPath := sourceFile.DepfilePath(ctx)
objPath := sourceFile.ObjectPath(ctx)
targetFilePath := utils.NULLFile()

// TODO: This should perhaps also compare against the
Expand All @@ -306,7 +308,7 @@ func findIncludesUntilDone(ctx *types.Context, cache *includeCache, sourceFile t
// TODO: This reads the dependency file, but the actual building
// does it again. Should the result be somehow cached? Perhaps
// remove the object file if it is found to be stale?
unchanged, err := builder_utils.ObjFileIsUpToDate(ctx, sourcePath, sourceFile.ObjectPath(ctx), sourceFile.DepfilePath(ctx))
unchanged, err := builder_utils.ObjFileIsUpToDate(ctx, sourcePath, objPath, depPath)
if err != nil {
return i18n.WrapError(err)
}
Expand Down

0 comments on commit cfc4fd0

Please sign in to comment.