Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sketch.always_export_binaries: true CLI config is ignored when compiling via gRPC API #1103

Closed
kittaakos opened this issue Dec 8, 2020 · 1 comment
Labels
topic: gRPC Related to the gRPC interface type: imperfection Perceived defect in any part of project

Comments

@kittaakos
Copy link
Contributor

Bug Report

If I add the following to the CLI config and compile via the gRPC API, the binaries do not end up in the sketch folder.

sketch:
  always_export_binaries: true

I have to explicitly set it in the code if I want the binary in my sketch folder.

const compilerReq = new CompileReq();
compilerReq.setExportBinaries(true);

Current behavior

Expected behavior

sketch.always_export_binaries: true is not ignored in the CLI config.

Environment

  • CLI version (output of arduino-cli version): 0.14.0-rc1
  • OS and platform:

Additional context

@per1234 per1234 reopened this Mar 30, 2021
@fstasi fstasi removed the type: bug label Sep 16, 2021
@rsora rsora added type: imperfection Perceived defect in any part of project topic: gRPC Related to the gRPC interface labels Sep 22, 2021
@umbynos
Copy link
Contributor

umbynos commented Nov 25, 2022

Fixed by #1171

@umbynos umbynos closed this as completed Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: gRPC Related to the gRPC interface type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

6 participants