Compile command doesn't resolve Sketch path correctly on Windows

[silvanocerza]

Bug Report

Current behavior

$ arduino-cli.exe compile -b arduino:avr:uno "C:\Users\The Alien\Documents\Arduino\Blink\"
Error during build: opening sketch: no valid sketch found in C:\Users\The Alien\Documents\Arduino: missing C:\Users\The Alien\Documents\Arduino\Arduino.ino

Calling the compile command on Windows using the Sketch folder searches for the Sketch main file in the parent folder.

Calling it with the Sketch main .ino file works as expected.

# Works correctly
$ arduino-cli.exe compile -b arduino:avr:uno "C:\Users\The Alien\Documents\Arduino\Blink\Blink.ino"
Sketch uses 924 bytes (2%) of program storage space. Maximum is 32256 bytes.
Global variables use 9 bytes (0%) of dynamic memory, leaving 2039 bytes for local variables. Maximum is 2048 bytes.

It also works when it shouldn't, all the following commands must fail:

$ arduino-cli.exe compile -b arduino:avr:uno "C:\Users\The Alien\Documents\Arduino\Blink\a\"
$ arduino-cli.exe compile -b arduino:avr:uno "C:\Users\The Alien\Documents\Arduino\Blink\Blink\"
$ arduino-cli.exe compile -b arduino:avr:uno "C:\Users\The Alien\Documents\Arduino\Blink\anything\"

Expected behavior

The following commands must work:

$ arduino-cli.exe compile -b arduino:avr:uno "C:\Users\The Alien\Documents\Arduino\Blink\"
$ arduino-cli.exe compile -b arduino:avr:uno "C:\Users\The Alien\Documents\Arduino\Blink\Blink.ino"

These instead must fail:

$ arduino-cli.exe compile -b arduino:avr:uno "C:\Users\The Alien\Documents\Arduino\Blink\a\"
$ arduino-cli.exe compile -b arduino:avr:uno "C:\Users\The Alien\Documents\Arduino\Blink\Blink\"
$ arduino-cli.exe compile -b arduino:avr:uno "C:\Users\The Alien\Documents\Arduino\Blink\anything\"

Environment

• CLI version (output of arduino-cli version): 0.18.1
• OS and platform: Windows x64

Additional context

[MatteoPologruto]

Using cli version 0.29.0, compile behaves as expected in all of the above mentioned cases:

• compile with sketch folder as path:

C:\Users\m.pologruto>arduino-cli version
arduino-cli  Version: 0.29.0 Commit: 76251df9 Date: 2022-11-17T09:21:37Z

C:\Users\m.pologruto>arduino-cli compile -b arduino:avr:uno C:\Users\m.pologruto\Documents\Arduino\blink\
Sketch uses 444 bytes (1%) of program storage space. Maximum is 32256 bytes.
Global variables use 9 bytes (0%) of dynamic memory, leaving 2039 bytes for local variables. Maximum is 2048 bytes.


Used platform Version Path
arduino:avr   1.8.3   C:\Users\m.pologruto\AppData\Local\Arduino15\packages\arduino\hardware\avr\1.8.3

• compile with sketch main .ino:

C:\Users\m.pologruto>arduino-cli compile -b arduino:avr:uno C:\Users\m.pologruto\Documents\Arduino\blink\blink.ino
Sketch uses 444 bytes (1%) of program storage space. Maximum is 32256 bytes.
Global variables use 9 bytes (0%) of dynamic memory, leaving 2039 bytes for local variables. Maximum is 2048 bytes.


Used platform Version Path
arduino:avr   1.8.3   C:\Users\m.pologruto\AppData\Local\Arduino15\packages\arduino\hardware\avr\1.8.3

• compile with random directories inside of sketch folder:

C:\Users\m.pologruto>arduino-cli compile -b arduino:avr:uno C:\Users\m.pologruto\Documents\Arduino\blink\a\
Error opening sketch: no such file or directory: C:\Users\m.pologruto\Documents\Arduino\blink\a

C:\Users\m.pologruto>arduino-cli compile -b arduino:avr:uno C:\Users\m.pologruto\Documents\Arduino\blink\blink\
Error opening sketch: no such file or directory: C:\Users\m.pologruto\Documents\Arduino\blink\blink

C:\Users\m.pologruto>arduino-cli compile -b arduino:avr:uno C:\Users\m.pologruto\Documents\Arduino\blink\anything\
Error opening sketch: no such file or directory: C:\Users\m.pologruto\Documents\Arduino\blink\anything

I'm closing the issue.