Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serial discovery support for m1 mac #617

Merged
merged 2 commits into from Mar 1, 2021
Merged

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Feb 15, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

feature

  • What is the current behavior?

#611

  • What is the new behavior?

try to make an experimental build to support for mac m1

  • Does this PR introduce a breaking change?
  • Other information:

@parreirat
Copy link

parreirat commented Feb 18, 2021

Hello.

I have an M1, @ 11.2.1, and am trying to get my Elegoo MEGA2560 R3 board running for the first time.

I cannot see the device displayed on ports at all.
Having the board plugged, or unplugged, does not register at all on the "System Report" USB devices.
Arduino 1.8.13.

I was trying to compile this PR on both Rosetta terminal (where I get a segfault just installing Go), and on the regular terminal (e.g. M1), and can't build it either:

image

I'd love to help you out somehow if I could, testing this and whatnot, if that would be useful.

@umbynos
Copy link
Contributor Author

umbynos commented Feb 19, 2021

Hi, thanks for your interest! I think the problem comes from the fact you are using https://github.com/bugst/go-serial/ version 1.1.1

Support for darwin amd64 was added in version 1.1.2 (here).

PS this PR is still a WIP, it's not ready yet. I think the board discovery still needs some work. The dep bump was only to use the correct version of the library with support for mac m1 (this library is used for the serial communication handling)

@umbynos umbynos marked this pull request as draft February 19, 2021 13:15
@parreirat
Copy link

Hi, thanks for your interest! I think the problem comes from the fact you are using https://github.com/bugst/go-serial/ version 1.1.1

Support for darwin amd64 was added in version 1.1.2 (here).

PS this PR is still a WIP, it's not ready yet. I think the board discovery still needs some work. The dep bump was only to use the correct version of the library with support for mac m1 (this library is used for the serial communication handling)

Hi! I got a different USB B cable today and seems that was the issue, it's working flawlessly now!

Thanks for your work! I'd be very happy to help with anything regarding M1 testing if you'd like :)

@umbynos umbynos requested a review from rsora March 1, 2021 08:52
@umbynos umbynos marked this pull request as ready for review March 1, 2021 09:36
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@umbynos umbynos force-pushed the umbynos/darwin_amd64_support branch from d744395 to 76ee176 Compare March 1, 2021 11:42
@umbynos
Copy link
Contributor Author

umbynos commented Mar 1, 2021

Serial discovery should be working now on the M1 (still missing the tools)
image

@umbynos umbynos changed the title Add support for m1 mac Add serial discovery support for m1 mac Mar 1, 2021
@umbynos umbynos merged commit 59e0f3e into devel Mar 1, 2021
@umbynos umbynos deleted the umbynos/darwin_amd64_support branch March 1, 2021 11:51
umbynos added a commit that referenced this pull request Mar 2, 2021
@rsora rsora added the topic: infrastructure Related to project infrastructure label Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants