Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SafeJoin in V2 Tools Install endpoint #840

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Sep 29, 2023

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

Security Fix

  • What is the current behavior?

The v2 install endpoint is vulnerable to path traversal vulnerability

  • What is the new behavior?

That is fixed (leveraging the SafeJoin function introduced in #821)

  • Does this PR introduce a breaking change?

No

  • Other information:

@umbynos umbynos added type: enhancement Proposed improvement topic: code Related to content of the project itself topic: security Related to the protection of user data labels Sep 29, 2023
@umbynos umbynos self-assigned this Sep 29, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (33080c3) 18.20% compared to head (cdac540) 18.37%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #840      +/-   ##
==========================================
+ Coverage   18.20%   18.37%   +0.16%     
==========================================
  Files          53       53              
  Lines        4109     4120      +11     
==========================================
+ Hits          748      757       +9     
- Misses       3256     3257       +1     
- Partials      105      106       +1     
Flag Coverage Δ
unit 18.37% <63.15%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
v2/pkgs/tools.go 68.82% <63.15%> (+0.89%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@umbynos umbynos merged commit 11acfc0 into main Oct 2, 2023
56 checks passed
@umbynos umbynos deleted the safe-join-install branch October 2, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself topic: security Related to the protection of user data type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants