Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add -i flag to upload a custom fw to a board #117

Merged
merged 3 commits into from Sep 30, 2021
Merged

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Sep 28, 2021

With this enhancement, a custom local firmware can be uploaded to a board using -i or --input-file flag:

./arduino-fwuploader firmware flash -i custom_fw.bin -b arduino:samd:mkr1000 -a /dev/ttyACM0

@umbynos umbynos added type: enhancement Proposed improvement topic: documentation Related to documentation for the project topic: code Related to content of the project itself labels Sep 28, 2021
@umbynos umbynos requested a review from a team September 28, 2021 10:38
@umbynos umbynos self-assigned this Sep 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2021

Codecov Report

Merging #117 (affb754) into main (9220c33) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   11.04%   10.96%   -0.08%     
==========================================
  Files          21       21              
  Lines        1793     1805      +12     
==========================================
  Hits          198      198              
- Misses       1537     1549      +12     
  Partials       58       58              
Flag Coverage Δ
unit 10.96% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cli/firmware/flash.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9220c33...affb754. Read the comment docs.

@umbynos
Copy link
Contributor Author

umbynos commented Sep 28, 2021

Needs a rebase after #116 gets merged

docs/usage.md Outdated Show resolved Hide resolved
Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested: works as expected

@umbynos umbynos merged commit 144292a into main Sep 30, 2021
@umbynos umbynos deleted the umbynos/input-file branch September 30, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself topic: documentation Related to documentation for the project type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants