Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add portenta C33 firmware to the plugin system #206

Merged
merged 1 commit into from Aug 21, 2023

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Jul 31, 2023

No description provided.

@umbynos umbynos added the topic: infrastructure Related to project infrastructure label Jul 31, 2023
@umbynos umbynos self-assigned this Jul 31, 2023
@alessio-perugini alessio-perugini added the status: on hold Do not proceed at this time label Aug 2, 2023
Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Self-future reminder: don't merge this before releasing the plugin and publish it to the general package_index.json

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 11.76% and project coverage change: +5.08% 🎉

Comparison is base (bb28293) 6.63% compared to head (f1747cf) 11.72%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##            main     #206      +/-   ##
=========================================
+ Coverage   6.63%   11.72%   +5.08%     
=========================================
  Files         24       20       -4     
  Lines       2154     1160     -994     
=========================================
- Hits         143      136       -7     
+ Misses      1953      971     -982     
+ Partials      58       53       -5     
Flag Coverage Δ
unit 11.72% <11.76%> (+5.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cli/arguments/arguments.go 0.00% <0.00%> (ø)
cli/certificates/flash.go 0.00% <0.00%> (ø)
cli/common/common.go 0.00% <0.00%> (ø)
cli/firmware/flash.go 0.00% <0.00%> (ø)
cli/firmware/getversion.go 0.00% <0.00%> (ø)
cli/firmware/list.go 0.00% <0.00%> (ø)
flasher/flasher.go 0.00% <ø> (ø)
indexes/download/download.go 29.75% <100.00%> (-2.63%) ⬇️
indexes/firmwareindex/firmwareindex.go 55.07% <100.00%> (+6.35%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessio-perugini alessio-perugini merged commit 1d89350 into main Aug 21, 2023
30 checks passed
@alessio-perugini alessio-perugini deleted the add-portenta-c33 branch August 21, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: on hold Do not proceed at this time topic: infrastructure Related to project infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the Portenta C33 firmware in the repository and integrate it with the existing system
3 participants