Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues with board index generator script #42

Merged
merged 2 commits into from May 27, 2021

Conversation

silvanocerza
Copy link
Contributor

Now generator.py replaces all the necessary parameters in the uploader.command field so the fwuploader will be able to run the upload tool, if that is not done the fwuploader simply lacks the information necessary to replaces those parameters since they're stored in various cores' boards.txt and platform.txt. The fwuploader assumes no core is installed so this had to be done.

I also had to handle a corner case for the Arduino Uno WiFi Rev2 since the upload.pattern in the arduino:megaavr core's platform.txt also assumes the bootloader will be uploaded, I solved this by compiling a Loader Sketch that includes the bootloader and by removing the upload.extra_files parameter.

Also I fixed all paths in the raw_boards.json since they were using my own environment paths, now generator.py can be run by anyone with ease.

@silvanocerza silvanocerza requested a review from a team May 27, 2021 16:03
@silvanocerza silvanocerza self-assigned this May 27, 2021
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏁

@rsora rsora requested a review from cmaglie May 27, 2021 16:48
@silvanocerza silvanocerza merged commit 2325713 into main May 27, 2021
@silvanocerza silvanocerza deleted the scerza/board_index_generator_fix branch May 27, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants