Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serial Monitor control icon background color does not reflect status when using Theia themes #1053

Closed
3 tasks done
per1234 opened this issue Jun 13, 2022 · 1 comment
Closed
3 tasks done
Assignees
Labels
conclusion: declined Will not be worked on topic: code Related to content of the project itself topic: serial monitor Related to the Serial Monitor topic: theme Related to GUI theming type: imperfection Perceived defect in any part of project

Comments

@per1234
Copy link
Contributor

per1234 commented Jun 13, 2022

Describe the problem

The behavior of the Arduino IDE's Serial Monitor can be controlled by the user via icons on the toolbar:

  • "Toggle Autoscroll"
  • "Toggle Timestamp"
  • "Clear Output"

The first two of these are toggles, where they alternate between an enabled and a disabled state on each click.

The current state of those two controls is indicated by coloration, most prominently by the background color (the foreground color does change, but almost imperceptibly).

🐛 When using the "Dark (Theia)" or "Light (Theia)" themes in the Arduino IDE, the background color of the icon no longer changes to indicate its state.

Icons enabled and disabled coloration with "Dark (Theia)" theme in Arduino IDE 2.0.0-rc6-snapshot-b8c718c:

image

(note the gray background of the "Toggle Autoscroll" indicates it is enabled, while the black background of "Toggle Timestamp" indicates it is disabled)

Icons enabled and disabled coloration with "Dark (Theia)" theme in Arduino IDE 2.0.0-rc7:

image

(note the "Toggle Autoscroll" icon has a black background even though it is enabled)

To reproduce

  1. Select File > Preferences... from the Arduino IDE menus.
  2. Select "Dark (Theia)" from the "Theme" menu.
  3. Click the OK button.
  4. Select Tools > Serial Monitor from the Arduino IDE menus to open the "Serial Monitor" view, if it is not already open.
  5. Click on the "Toggle Autoscroll" and "Toggle Timestamp" toolbar icons.
    🐛 The background color does not change.
  6. Select File > Preferences... from the Arduino IDE menus.
  7. Select "Light (Theia)" from the "Theme" menu.
  8. Click the OK button.
  9. Click on the "Toggle Autoscroll" and "Toggle Timestamp" toolbar icons.
    🐛 The background color does not change.

Expected behavior

Serial Monitor control icon background color reflects the state.

Arduino IDE version

Original report

2.0.0-rc7

Last verified with

2.0.0-rc8-snapshot-f4a68e7

Operating system

Windows, Linux

Operating system version

Windows 10, Ubuntu 20.04

Additional context

I bisected the introduction of the issue to 1ae60ec (does not occur when using the build for b8c718c).


Originally reported at https://forum.arduino.cc/t/monitor-toggle-autoscroll/1001575


The issue does not affect the other themes ("High Contrast (Theia)", "Light (Arduino)", "Dark (Arduino)")

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jun 13, 2022
@per1234 per1234 added the topic: serial monitor Related to the Serial Monitor label Jun 24, 2022
@per1234 per1234 added the topic: theme Related to GUI theming label Jul 4, 2022
@per1234
Copy link
Contributor Author

per1234 commented Aug 3, 2022

Closing as declined because the "Dark (Theia)" and "Light (Theia)" themes are no longer supported by Arduino: #1283

@per1234 per1234 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2022
@per1234 per1234 assigned per1234 and unassigned francescospissu Aug 3, 2022
@per1234 per1234 added the conclusion: declined Will not be worked on label Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: declined Will not be worked on topic: code Related to content of the project itself topic: serial monitor Related to the Serial Monitor topic: theme Related to GUI theming type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

2 participants