Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make editor hover less intrusive #21

Open
per1234 opened this issue Feb 15, 2021 · 7 comments
Open

Make editor hover less intrusive #21

per1234 opened this issue Feb 15, 2021 · 7 comments
Assignees
Labels
criticality: high Of high impact topic: language server Related to the Arduino Language Server type: enhancement Proposed improvement

Comments

@per1234
Copy link
Contributor

per1234 commented Feb 15, 2021

Is your feature request related to a problem? Please describe.

The editor hover seems unnecessarily large. It covers up a lot of the code, which is especially annoying/distracting when it is triggered inadvertently.


editorhover


Describe the solution you'd like

  • Make the font size of the title the same as the editor font.
  • Remove the unnecessary vertical padding from the title.

Environment

OS: Windows 10
Version: 2.0.0-beta.2-snapshot.298cc11
Date: 2021-02-15T14:16:52.603Z
CLI Version: 0.16.0 alpha [c977a238]

Additional context

I also notice there are some strange horizontal rules in the hover that don't have any alignment with the text.

Related: #51

@per1234 per1234 added the type: enhancement Proposed improvement label Feb 15, 2021
@kittaakos

This comment has been minimized.

@kittaakos

This comment has been minimized.

@trlafleur
Copy link

Would be nice to be able to set the delay time prior to pop-up, it's now in my opinion way too short...

Mac 11.1
IDE 2.0.0b3

@ubidefeo ubidefeo added the priority: high Resolution is a high priority label Mar 20, 2021
@pinnet
Copy link

pinnet commented Mar 21, 2021

the IDE is currently unusable as the pop ups just get in the way if you edit with the mouse.

@kittaakos
Copy link
Contributor

the pop ups just get in the way if you edit with the mouse.

See here: arduino/arduino-language-server#68

@ubidefeo ubidefeo added priority: low Resolution is a low priority and removed priority: low Resolution is a low priority labels Mar 22, 2021
@per1234
Copy link
Contributor Author

per1234 commented Oct 22, 2021

Regarding these:

  • Make the font size of the title the same as the editor font.
  • Remove the unnecessary vertical padding from the title.

Some time back, Akos kindly helped me to understand this situation better. I forgot to post an update to the issue after that though so I will do that now:

The formatting for the hover text is provided by the clangd C++ language server used by the Arduino Language Server. For the example used here, it looks like this:

{
  "id": 11,
  "jsonrpc": "2.0",
  "result": {
    "contents": {
      "kind": "markdown",
      "value": "### function `pinMode`  \n\n---\n→ `void`  \nParameters:  \n- `uint8_t pin`\n- `uint8_t mode`\n\n---\n```cpp\nvoid pinMode(uint8_t pin, uint8_t mode)\n```"
    },
    "range": {
      "end": { "character": 9, "line": 34 },
      "start": { "character": 2, "line": 34 }
    }
  }
}

So the large font size of the first line of the hover results from the rendering of the H3 heading (as specified by the Markdown markup ###).

VS Code with the clangd extension produces an identical intrusive hover for C++ code:

image

@per1234 per1234 added the topic: language server Related to the Arduino Language Server label Oct 29, 2021
@rsora rsora added criticality: high Of high impact and removed priority: high Resolution is a high priority labels Nov 2, 2021
@mklemarczyk
Copy link

I have no problem with the popup on hover, it takes for me too much time to display it.
Arduino IDE 2.0.0-rc5 on Windows 10.

@per1234 per1234 mentioned this issue Sep 27, 2022
3 tasks
@kittaakos kittaakos mentioned this issue Sep 28, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
criticality: high Of high impact topic: language server Related to the Arduino Language Server type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

8 participants