Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chorded keyboard shortcuts not shown in menus #945

Open
3 tasks done
maciejmiklas opened this issue Apr 6, 2022 · 1 comment
Open
3 tasks done

Chorded keyboard shortcuts not shown in menus #945

maciejmiklas opened this issue Apr 6, 2022 · 1 comment
Assignees
Labels
topic: code Related to content of the project itself topic: theia Related to the Theia IDE framework type: imperfection Perceived defect in any part of project

Comments

@maciejmiklas
Copy link

maciejmiklas commented Apr 6, 2022

Describe the problem

In addition to standard keyboard shortcuts, Arduino IDE supports "chords", where two separate keypress actions are performed sequentially.

🐛 The shortcut is not shown in Arduino IDE menus when a chord was assigned to the command.

To reproduce

  1. Right click on the editor view.
  2. Note that no keyboard is shown to the right of the "Format Selection" menu item.
  3. Select File > Advanced > Keyboard Shortcuts from the Arduino IDE menus.
    A "Keyboard Shortcuts" view will open in the main panel.
  4. In the "Search keybindings" field of the view, type Format Selection

🐛 The command has a keyboard shortcut Ctrl+K Ctrl+F, but it was not shown in the menu.

Expected behavior

Keyboard shortcuts are always shown in the menus when the command has one assigned.

Arduino IDE version

3a70547

Operating system

  • Windows
  • Linux

Operating system version

  • Windows 10
  • Ubuntu 21.10

Additional context

In previous versions of the IDE (c. 2.0.0-rc5), a keyboard shortcut was shown in the menu, but it was only the last part of the chord (e.g., "Ctrl+F" for the Ctrl+K Ctrl+F shortcut).

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@maciejmiklas maciejmiklas added the type: imperfection Perceived defect in any part of project label Apr 6, 2022
@per1234 per1234 changed the title Keyboard shortcuts in context menu on Ubuntu are incorrect in 2.0.0-rc5 Keyboard shortcuts in context menu are incorrect Apr 6, 2022
@per1234
Copy link
Contributor

per1234 commented Apr 6, 2022

I believe it is this bug:

eclipse-theia/theia#1199

@per1234 per1234 added topic: code Related to content of the project itself topic: theia Related to the Theia IDE framework labels Apr 6, 2022
@per1234 per1234 changed the title Keyboard shortcuts in context menu are incorrect Chorded keyboard shortcuts not shown in menus Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself topic: theia Related to the Theia IDE framework type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

3 participants