Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a no-op workspace/didChangeConfiguration (#114) #121

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Implement a no-op workspace/didChangeConfiguration (#114) #121

merged 1 commit into from
Jul 5, 2022

Conversation

joewreschnig
Copy link
Contributor

Please check if the PR fulfills these requirements

  • What kind of change does this PR introduce?
    Better client compatibility.
  • What is the current behavior?
    When connecting with default eglot settings, the server panics when eglot calls an unimplemented method.
  • What is the new behavior?
    It does not crash.

@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jun 23, 2022
@cmaglie cmaglie merged commit 0384c34 into arduino:main Jul 5, 2022
@cmaglie cmaglie mentioned this pull request Jul 5, 2022
Closed
3 tasks
@cmaglie
Copy link
Member

cmaglie commented Jul 5, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

Assignees

@cmaglie cmaglie

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joewreschnig @cmaglie @per1234