Manual builds must not publish when not on master. #36
Conversation
Only CRON job and `workflow_dispatch` from the `master` should publish a new nightly to AWS. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos
force-pushed
the
run-publish-only-from-master
branch
from
9780eda
to
17214d3
Compare
There was a problem hiding this comment.
What do you think? Does it have value?
The truth is that I don't know enough about how the build artifacts are consumed during development to be able to make a judgement call on whether there is any value in having artifacts from manual builds done on development branches on AWS.
But I'm certain that you know exactly what are the needs for these artifacts, so I'm happy to accept your judgment on that.
As far as the change to the workflow goes, it looks great. Because I am not very experienced with the workflow_dispatch trigger, I gave it a try in my fork and it worked just as expected.
The Arduino LS is not versioned. No releases are available. The latest "stable" version is always the nightly. Currently, the IDE2 workflow always pulls the nightly Arduino LS. My intention was to avoid accidentally publishing a LS as the nightly from a random, dev branch. |
Only CRON job and
workflow_dispatchfrom themastershould publisha new nightly to AWS.
Signed-off-by: Akos Kitta kittaakos@typefox.io
@per1234, I made this PR to avoid publishing a nightly from a random branch when starting the workflow manually. What do you think? Does it have value? Thanks!