Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update set-output cmds #91

Merged
merged 1 commit into from
Mar 24, 2023
Merged

update set-output cmds #91

merged 1 commit into from
Mar 24, 2023

Conversation

2bndy5
Copy link
Contributor

@2bndy5 2bndy5 commented Jan 3, 2023 •
edited by per1234

I use this action in a number of large matrix jobs, so I get a lot of repeated warnings.

2bndy5 added a commit to nRF24/RF24Network that referenced this pull request Jan 3, 2023
@2bndy5
test arduino/compile-sketches#91 PR
0df13a7
@2bndy5
Copy link
Contributor Author

2bndy5 commented Feb 3, 2023

pinging @arduino team.

@MathewHDYT
Copy link

As mentioned in the corresponding issue #86.

@per1234 Would be nice if this could be merged, if this isn't done than according to this blog post by GitHub actions using the set-output or set-state, will simply fail starting 1st June 2023.

@arduino arduino locked as too heated and limited conversation to collaborators Feb 18, 2023
@2bndy5 2bndy5 mentioned this pull request Mar 24, 2023
Merged
@per1234 per1234 self-assigned this Mar 24, 2023
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: infrastructure Related to project infrastructure labels Mar 24, 2023
@arduino arduino unlocked this conversation Mar 24, 2023
per1234
per1234 approved these changes Mar 24, 2023
View reviewed changes
Copy link
Collaborator

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @2bndy5

I apologize for being slow to review this important contribution, and also for not having taken the time to merge your valid fix to the action setup script before the recent rework of that system obviated it.

@per1234 per1234 merged commit 8ef4106 into arduino:main Mar 24, 2023
@2bndy5 2bndy5 deleted the fix-86 branch March 24, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

Assignees

@per1234 per1234

Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@2bndy5 @MathewHDYT @per1234