Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libusb-win32 and bump ncurses #8

Merged
merged 3 commits into from
Nov 2, 2022
Merged

Conversation

umbynos
Copy link
Collaborator

@umbynos umbynos commented Oct 28, 2022

I removed libusb-win32 and replaced it with libusb-compat because of arduino/avrdude-packing#15. After the removal of that lib, the build on win was not working anymore:

/usr/bin/i686-w64-mingw32-ld: /opt/lib/i686-w64-mingw32/lib/libtinfo.a(lib_ttyflags.o):lib_ttyflags.c:(.text+0x6b): undefined reference to `_nc_mingw_ioctl'
/usr/bin/i686-w64-mingw32-ld: /opt/lib/i686-w64-mingw32/lib/libtinfo.a(lib_ttyflags.o):lib_ttyflags.c:(.text+0xeb): undefined reference to `_nc_mingw_ioctl'
collect2: error: ld returned 1 exit status
make[2]: *** [src/CMakeFiles/avrdude.dir/build.make:156: src/avrdude] Error 1

after compiling ncurses 5.9 with these flags, I was getting another error:

/usr/bin/i686-w64-mingw32-ld: /opt/lib/i686-w64-mingw32/lib/libtinfo.a(lib_setup.o):lib_setup.c:(.text+0x442): undefined reference to `_nc_get_driver'
/usr/bin/i686-w64-mingw32-ld: /opt/lib/i686-w64-mingw32/lib/libtinfo.a(lib_setup.o):lib_setup.c:(.text+0x447): undefined reference to `_nc_get_driver'

This led me to update ncurses to the latest version avalable: 6.3. After that the flags --with-termlib --enable-termcap were not usable at the same time. That's why I removed --with-termlib

@mcuee
Copy link

mcuee commented Oct 30, 2022

Copy link

@mcuee mcuee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good change to adopted.

@mcuee
Copy link

mcuee commented Oct 30, 2022

@umbynos umbynos merged commit 08cd49e into main Nov 2, 2022
@umbynos umbynos deleted the remove-libusb-win32 branch November 2, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: windows Specific to Windows operating system type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants