feat: port ble_scratch code to rp2040 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucarin91
commented
May 31, 2024
sketches/BLE_Scratch/BLE_Scratch.ino
Outdated
| } | ||
| #endif | ||
|
|
||
| // get binary leading config and interpret as string | ||
| uint8_t cfg[100]; | ||
| auto n = get_config_bytes(cfg, 100); | ||
| // auto n = get_config_bytes(cfg, 100); |
There was a problem hiding this comment.
- implement the config parsing
lucarin91
commented
May 31, 2024
dido18
reviewed
May 31, 2024
| while (!Serial) | ||
| ; | ||
| Serial.println("Started"); | ||
| while (!Serial); |
There was a problem hiding this comment.
What happens if we remove this check ? because the blocking check block the code if the serial is not attached.
could we simply go ahead and ignore the serial ?
| @@ -1,37 +1,49 @@ | |||
| // BLE Scratch v3 / Connect BLE Sense boards to Scratch via Bluetooth | |||
| // 2023.03.04 Added support for BLE Sense R2 and STOPSERVO command | |||
There was a problem hiding this comment.
Suggested change
| // 2023.03.04 Added support for BLE Sense R2 and STOPSERVO command | |
| // 2023.03.04 Added support for BLE Sense R2 and STOPSERVO command | |
| // 2024.05.31 Added support for RP2040 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.