feat: show the Button status for the include robot extension #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dido18
force-pushed
the
inlcude-robot-show-status-button
branch
from
f47a3de
to
d1d0fd6
Compare
lucarin91
reviewed
Jun 11, 2024
| @@ -88,6 +85,8 @@ class IncludeRobot { | |||
| * @type {Runtime} | |||
| */ | |||
| this._runtime = runtime; | |||
|
|
|||
| this._device = new Peripheral(this._runtime, IncludeRobot.EXTENSION_ID); | |||
There was a problem hiding this comment.
I will keep the same device singleton at least, in this way we can still reuse the same connection for both extension
There was a problem hiding this comment.
I hoped but unfortunately we can't.
The Peripheral needs the ID of the extension to "register" the popup to the button.
There was a problem hiding this comment.
I don't think that this is an issue, you can still reuse the connection.
There was a problem hiding this comment.
What is the objective to maintain a single BLE connection?
If it is related to be able to manage both the extensions, the same result could be obtained even with two different connections. This is possible by connecting both extensions.
This is an example:
- I connected both the extensions to the robot
- I managed to see the data coming from the BLE Sense and to send the command.
lucarin91
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connection button status was shared among the
Arduino Include robotand theBLE Arduino Senseextensions.Add the button to the
Arduino include robotextension.NOTE: the shared
DEVICEhas been removed.