Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 107-Arduino-UAVCAN with 107-Arduino-Cyphal. #1489

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Replace 107-Arduino-UAVCAN with 107-Arduino-Cyphal. #1489

merged 1 commit into from
Jun 20, 2022

Conversation

aentinger
Copy link
Contributor

Since the original project underwent a name change (see here) the library was also renamed. Consequently 107-Arduino-UAVCAN shall only be distributed via the library manager up until v1.4.0. First version of 107-Arduino-Cyphal is v2.0.0.

@github-actions
Copy link
Contributor

Hi @aentinger.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added the topic: modification Change existing list entry label Jun 14, 2022
@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/107-systems/107-Arduino-Cyphal:

Linting library in 107-Arduino-Cyphal
WARNING: library.properties name value 107-Arduino-Cyphal is longer than the recommended length of 16 characters. (Rule 
         LP010)                                                                                                         
WARNING: Library name 107-Arduino-Cyphal contains "Arduino". This is superfluous. (Rule LP014)
ERROR: Library name 107-Arduino-Cyphal not found in the Library Manager index.                                          
       Library names are not allowed to change after being added to the index. See:                                     
       https://github.com/arduino/Arduino/wiki/Library-Manager-FAQ#how-can-i-change-my-librarys-name (Rule LP018)       

Linter results for project: 1 ERRORS, 2 WARNINGS

-------------------

Linting sketch in 107-Arduino-Cyphal/examples/OpenCyphal-BMS-Subscribe

Linter results for project: no errors or warnings

-------------------

Linting sketch in 107-Arduino-Cyphal/examples/OpenCyphal-Blink

Linter results for project: no errors or warnings

-------------------

Linting sketch in 107-Arduino-Cyphal/examples/OpenCyphal-GNSS-Node

Linter results for project: no errors or warnings

-------------------

Linting sketch in 107-Arduino-Cyphal/examples/OpenCyphal-Heartbeat-Publish

Linter results for project: no errors or warnings

-------------------

Linting sketch in 107-Arduino-Cyphal/examples/OpenCyphal-Heartbeat-Subscribe

Linter results for project: no errors or warnings

-------------------

Linting sketch in 107-Arduino-Cyphal/examples/OpenCyphal-Service-Client

Linter results for project: no errors or warnings

-------------------

Linting sketch in 107-Arduino-Cyphal/examples/OpenCyphal-Service-Server

Linter results for project: no errors or warnings

-------------------

Linting sketch in 107-Arduino-Cyphal/examples/OpenCyphal-ToF-Distance-Sensor-Node

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 2 WARNINGS

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @aentinger
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 June 14, 2022 11:17
@per1234 per1234 added the topic: URL change Change library repository URL label Jun 14, 2022
@per1234 per1234 added the status: pending backend Depends on backend maintenance operations label Jun 14, 2022
@per1234
Copy link
Contributor

per1234 commented Jun 14, 2022

I am confirming your request @aentinger.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests and closes the pull requests when it is done. You will get a notification from GitHub at that time.

After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager

@aentinger
Copy link
Contributor Author

The Library Manager index maintainer occasionally comes through to clear all the outstanding requests and closes the pull requests when it is done.

I understand 👍 .

Will it be necessary to resolve the Arduino Linter error? (I don't think so, but I can do that of course by changing from update to submit).

@per1234
Copy link
Contributor

per1234 commented Jun 14, 2022

Will it be necessary to resolve the Arduino Linter error?

No. That is not necessary. It is caused by the fact that there are actually two changes happening at once:

  • Change URL from https://github.com/107-systems/107-Arduino-UAVCAN.git to https://github.com/107-systems/107-Arduino-Cyphal
  • Change name from 107-Arduino-UAVCAN to 107-Arduino-Cyphal

The automated system can correctly validate the URL change, but does have any handling for name changes because that is done exclusively in the registration data. But this is no problem because both operation are processed manually anyway. In this case, the bot only tries to assist the maintainer by taking care of basic validation (i.e., is the new URL valid), but is not designed to handle even the URL change alone in a completely automated fashion.

@umbynos
Copy link
Contributor

umbynos commented Jun 20, 2022

Done in #1490 (comment)

@umbynos umbynos self-assigned this Jun 20, 2022
@umbynos umbynos added the conclusion: resolved Issue was resolved label Jun 20, 2022
@umbynos umbynos merged commit 45c06a7 into arduino:main Jun 20, 2022
@per1234 per1234 removed the status: pending backend Depends on backend maintenance operations label Apr 29, 2023
@per1234 per1234 removed the topic: modification Change existing list entry label Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: URL change Change library repository URL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants