Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repositories.txt #3151

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Update repositories.txt #3151

merged 1 commit into from
Aug 1, 2023

Conversation

Mtalat
Copy link
Contributor

@Mtalat Mtalat commented Aug 1, 2023

Add 1NCE Arduino blueprint

@github-actions github-actions bot added the topic: submission Add library to the list label Aug 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

A problem was found with your submission https://github.com/1NCE-GmbH/blueprint_arduino

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Thanks for your interest in contributing to the Arduino Library Manager index @Mtalat
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@Mtalat
Copy link
Contributor Author

Mtalat commented Aug 1, 2023

@ArduinoBot

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Arduino Lint has suggestions for possible improvements to https://github.com/1NCE-GmbH/blueprint_arduino:

Linting library in blueprint_arduino
INFO: No header file found matching library name (1NCE_Arduino_Blueprint.h). Best practices are for primary header      
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value 1NCE Arduino Blueprint is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format      
         (Rule LP010)                                                                                                
WARNING: Library name 1NCE Arduino Blueprint contains "Arduino". This is superfluous.                          
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP014)                                                                                          
WARNING: library.properties name 1NCE Arduino Blueprint contains spaces. Although supported, best practices is to not   
         use spaces.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   

Linter results for project: 0 ERRORS, 3 WARNINGS

-------------------

Linting sketch in blueprint_arduino/examples/nce_coap_demo

Linter results for project: no errors or warnings

-------------------

Linting sketch in blueprint_arduino/examples/nce_lwm2m_demo

Linter results for project: no errors or warnings

-------------------

Linting sketch in blueprint_arduino/examples/nce_udp_demo

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 3 WARNINGS

@github-actions github-actions bot merged commit aa0c558 into arduino:main Aug 1, 2023
12 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/1NCE-GmbH/blueprint_arduino/

github-actions bot pushed a commit that referenced this pull request Aug 1, 2023
@Mtalat Mtalat deleted the patch-1 branch August 1, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant