Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated default protoc version from 23.x to 26.x #100

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

pdebakker-auguria
Copy link
Contributor

Despite the readme saying that if you omit the version you will get the latest version, it actually installs version 23.x.
This one is outdated, and so I updated the default value to 26.x.

I'd prefer to see it not so hardcoded, but I figured this was a good short-term solution for the time being.

@CLAassistant
Copy link

CLAassistant commented Mar 20, 2024

CLA assistant check
All committers have signed the CLA.

@alessio-perugini
Copy link
Contributor

I will merge this without tagging a new minor. When we will implement the logic that automatically retrieve the latest I'd go with a minor bump

@alessio-perugini alessio-perugini merged commit 91b36bb into arduino:master Mar 20, 2024
12 checks passed
@pdebakker-auguria
Copy link
Contributor Author

Wow that was fast.
@alessio-perugini thank you for approving it.

I do have a question. I wanted to run this locally to test, but while I see a docs folder with a file called contributors.md, I dont see what steps I need to do to get things up and running locally.

Could you please tell me?

@alessio-perugini
Copy link
Contributor

@pdebakker-auguria Sure locally you'll need to have node v20 you can use the awesome https://github.com/nvm-sh/nvm?tab=readme-ov-file#installing-and-updating
to manage multiple node installation.

Assuming you have already installed node and git and running on linux/mac

git clone git@github.com:arduino/setup-protoc.git
cd setup-protoc

npm install
npm run test

Should be enough to have the test running

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants