Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds (back?) auto Beamer detection #203

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Aerijo
Copy link
Collaborator

@Aerijo Aerijo commented Nov 27, 2018

Description of the Change

Uses the contentRegex property contingent on atom/first-mate#109 and atom/atom#18499 to look for \documentclass{beamer} over multiple lines, and apply a penalty if it fails.

Alternate Designs

The current score method for firstLineMatch does not apply a penalty for failures, and Beamer was sometimes getting an edge over LaTeX when it shouldn't. This new property does penalize failure, so works well.

Benefits

Beamer will be auto applied

Possible Drawbacks

NA. It would take some weird source to trick it into matching wrongly.

Applicable Issues

#189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant