Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script asset type #59

Closed
Thomva opened this issue Sep 24, 2022 · 2 comments
Closed

Script asset type #59

Thomva opened this issue Sep 24, 2022 · 2 comments

Comments

@Thomva
Copy link
Contributor

Thomva commented Sep 24, 2022

I would like to use the same app.js (with my Vue setup) in Blast as in my project (with Vite), but when I add app.js to the config, it doesn't work because the type of the <script> is text/javascript instead of module.
Thomva added a commit to Thomva/blast that referenced this issue Sep 24, 2022
@Thomva
Add js_type config option (area17#59)
b1c5afb
@Thomva
Copy link
Contributor Author

Thomva commented Sep 24, 2022

I have added a config option for this: #60

Thomva added a commit to Thomva/blast that referenced this issue May 15, 2023
@Thomva
Revert "Add js_type config option (area17#59)"
56bb506 
This reverts commit b1c5afb.
Thomva added a commit to Thomva/blast that referenced this issue Jan 4, 2024
@Thomva
Separate js asset types & update docs (area17#59)
6621e4f
@Thomva
Copy link
Contributor Author

Thomva commented Feb 2, 2024

Hi, I have commented on the PR and applied the requested changes

mrtimbrook pushed a commit that referenced this issue Feb 14, 2024
@Thomva
Add js_type config option (#59) (#60)
3080e73 
* Add js_type config option (#59)

* Separate js asset types & update docs (#59)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrtimbrook @Thomva