Skip to content

Commit

Permalink
fixed a17-button triggering twice and some styling issues related to …
Browse files Browse the repository at this point in the history
…slots
  • Loading branch information
zeezo887 committed Apr 22, 2024
1 parent 7b24e02 commit 978f240
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 19 deletions.
16 changes: 8 additions & 8 deletions frontend/js/components/Button.vue
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@
render: function () {
const elOpts = {
class: this.buttonClasses,
onClick: (event) => {
this.onClick(event)
}
// onClick: (event) => {
// this.onClick(event)
// }
}
// button
Expand Down Expand Up @@ -183,7 +183,7 @@
font-weight:600;
padding: 0 15px;
.icon {
:deep(.icon) {
vertical-align: baseline;
top: 3px;
position: relative;
Expand Down Expand Up @@ -382,7 +382,7 @@
color: $color__icons;
@include monospaced-figures('off'); // dont use monospaced figures here
.icon {
:deep(.icon) {
transition: color .25s linear;
}
Expand All @@ -391,12 +391,12 @@
border-color: $color__text;
color: $color__text;
.icon {
:deep(.icon) {
color: $color__text;
}
}
.icon {
:deep(.icon) {
// vertical-align: top;
// height: 100%;
display: block;
Expand All @@ -420,7 +420,7 @@
color: $color__button_greyed;
background: $color__button_greyed--bg;
.icon {
:deep(.icon) {
color: $color__button_greyed;
}
Expand Down
12 changes: 6 additions & 6 deletions frontend/js/components/ButtonBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@
border-radius: 2px;
display: flex;
> a,
> button {
> :slotted(a),
> :slotted(button) {
@include btn-reset;
height: $toolbar__height - 2px;
line-height: $toolbar__height - 2px;
Expand Down Expand Up @@ -80,14 +80,14 @@
}
}
> a:first-child,
> button:first-child {
> :slotted(a):first-child,
> :slotted(button):first-child {
border-top-left-radius: $border__radius;
border-bottom-left-radius: $border__radius;
}
> a:last-child,
> button:last-child {
> :slotted(a):last-child,
> :slotted(button):last-child {
border-top-right-radius: $border__radius;
border-bottom-right-radius: $border__radius;
border-right: 0 none;
Expand Down
5 changes: 5 additions & 0 deletions frontend/js/components/CheckboxGroup.vue
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@
default: function () { return [] }
}
},
data () {
return {
hasLocale: false
}
},
mixins: [InputframeMixin, CheckboxMixin, FormStoreMixin],
computed: {
checkboxClasses: function () {
Expand Down
2 changes: 1 addition & 1 deletion frontend/js/components/Filter.vue
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@
margin-left:9px;
}
div {
:slotted(div) {
display:inline-block;
button:not(.button--validate), a{
Expand Down
2 changes: 1 addition & 1 deletion frontend/js/components/StickyNav.vue
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@
}
}
.stickyNav__actions > div {
.stickyNav__actions > :slotted(div) {
display:flex;
.button {
Expand Down
10 changes: 7 additions & 3 deletions frontend/js/components/blocks/BlockEditorItem.vue
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,7 @@
}
> button,
> :slotted(button),
.dropdown,
.dropdown > button {
display: inline-block;
Expand All @@ -289,7 +290,8 @@
}
.block__actions {
button[data-action] {
button[data-action],
:slotted(button)[data-action] {
visibility: hidden;
}
Expand All @@ -308,15 +310,17 @@
}
}
button[data-action] {
button[data-action],
:slotted(button)[data-action] {
visibility: visible;
display: inline-block;
}
}
.block__header:hover,
.block--focus .block__header {
button[data-action] {
button[data-action],
:slotted(button)[data-action] {
display: inline-block;
}
}
Expand Down

0 comments on commit 978f240

Please sign in to comment.