Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeater Collapse All Only Works Once #1330

Closed
freshleafmedia opened this issue Dec 21, 2021 · 1 comment · Fixed by #1348
Closed

Repeater Collapse All Only Works Once #1330

freshleafmedia opened this issue Dec 21, 2021 · 1 comment · Fixed by #1348

Comments

@freshleafmedia
Copy link
Contributor

freshleafmedia commented Dec 21, 2021

Description

The Collapse all feature for repeaters only works the first time it's clicked, or if items are initially collapsed not at all

Steps to reproduce

  1. Create a block which has a repeater
  2. populate the repeater with items
  3. Click the Collapse all link
  4. Expand the now collapsed items
  5. Click the Collapse all link again

Expected result

Repeated items would be collapsed

Actual result

Repeated items remain expanded

Versions

Twill version: 2.x-dev (2523336)
Laravel version: 8.76.1
PHP version: 8.1.0
Database engine: MySQL 5.7.34

@haringsrob
Copy link
Contributor

Hey @freshleafmedia,

Thank you for reporting this issue. I have added a pull request with a fix here: #1348

Kind regards,

haringsrob added a commit that referenced this issue Jan 12, 2022
haringsrob added a commit that referenced this issue Jan 12, 2022
ifox pushed a commit that referenced this issue Jan 13, 2022
ifox pushed a commit that referenced this issue Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants