Fix Exception Handler broken for Laravel 8 #1095
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As Twill is replacing (by default) the Laravel Exception Handler, on Laravel 8 this has some bad outcomes. As the handler now uses the
App\Exceptions\Handler::register()
method to register new closure handlers, this method is never called by Twill and this would never work:Solution
Instead of extending
Illuminate\Foundation\Exceptions\Handler
, we can probably extendApp\Exceptions\Handler
as this class will always exist on new Laravel applications and it also extends Laravel's Exception handler.