Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report and throw errors in production #2579

Closed
wants to merge 44 commits into from
Closed

Conversation

AidasK
Copy link

@AidasK AidasK commented May 4, 2024

Errors are not reported and displayed on production. This mr is based on #2540 issue and based on a discussion on discord https://discord.com/channels/811936425858695198/811986440569356308/1219656775125700748

@CLAassistant
Copy link

CLAassistant commented May 4, 2024

CLA assistant check
All committers have signed the CLA.

ifox and others added 29 commits May 4, 2024 13:35
* Fix getBaseNamespace

* Add tests

* Given getBasePath is broken and not used anywhere, remove it

* Fix tests

* Update CapsulesTest.php
It's 2024, all browsers already have support for this
Bumps [axios](https://github.com/axios/axios) from 0.27.2 to 0.28.0.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v0.28.0/CHANGELOG.md)
- [Commits](axios/axios@v0.27.2...v0.28.0)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
id is the correct locale for Indonesian, there are no in locale defined in ISO standard.
he the correct locale for Hebrew, there are no iw locale defined in ISO standard.
yd the correct locale for Yiddish, ji is deprecated.
…in the config

## Description

If you create a model, then add a new language in the translatable config and try to save this save model you will get an error `Cannot set property 'active' on null` because it's trying to get a translation that doesn't yet exist

This PR fixes this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants