Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the "offset 'en'" error while updating a setting form which include translate disabled field #91

Closed
wants to merge 5 commits into from
Closed

Fixed the "offset 'en'" error while updating a setting form which include translate disabled field #91

wants to merge 5 commits into from

Conversation

yanhao-li
Copy link

@yanhao-li yanhao-li commented Nov 26, 2018

Reference: #50
This PR include the following two commits,
The first commit fixed the error happened when update the setting, by improving the setting update strategy.
The second commit changed A17TextField's value render strategy by converting the passed value to a reasonable string, avoid the situation that in some cases, it will display "[object object]", not only in this case, but also may happen elsewhere.

@ifox
Copy link
Member

ifox commented Dec 12, 2018

Thanks for this @yanhao-li! As discussed earlier today, another PR got merged which included a fix for this #87. Also see 2570c5f and 8d251f1 for some more related commits.

To avoid displaying [object object] I found a solution in the form field blade file, when the vuex store content is outputted inline, because that's the only part of the code that knows if the developer intend to make the field translatable. Settings should now work in various configurations that weren't supported before 👍

@yanhao-li
Copy link
Author

Awesome, Thanks @ifox

@yanhao-li yanhao-li deleted the fix-setting-update-without-translated branch February 4, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants