Fix 'undefined' and 'null' being returned by the frontend #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We bumped into this bug today, with @luislavena, so this is a hot fix, as the source of this problem is the frontend.
Locally it all was working fine but when when we deployed to a staging server the frontend was able to upload the file to S3 but when POSTing to our backend it it was alternately sending
nullandundefinedin the propertymedia_to_replace_id, generating the error seen on this issue.I believe
is_numericcovers all possibilities, unless users are using UUIDs as Twill database keys, which seems like very edge cases.Closes #957.