Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only call SetVSAmplitude if the camera supports it. #49

Open
MarkRivers opened this issue Feb 5, 2022 · 3 comments
Open

Only call SetVSAmplitude if the camera supports it. #49

MarkRivers opened this issue Feb 5, 2022 · 3 comments

Comments

@MarkRivers
Copy link
Member

Commit 5e34010 from @pheest added code that unconditionally calls SetVSAmplitude. This fails on cameras that don't support that call.

@pheest is there a way to determine if SetVSAmplitude is supported on a given camera, and skip that block if it is?

@MarkRivers
Copy link
Member Author

See #48 for some details.

@pheest
Copy link
Contributor

pheest commented Feb 7, 2022 via email

@pheest
Copy link
Contributor

pheest commented Feb 7, 2022

The required code fragment would be:
if ((mCapabilities.ulSetFunctions & AC_SETFUNCTION_VSAMPLITUDE) != 0)
{
asynPrint(this->pasynUserSelf, ASYN_TRACE_FLOW,
"%s:%s:, SetVSAmplitude(%d)\n",
driverName, functionName, verticalShiftAmplitude);
checkStatus(SetVSAmplitude(verticalShiftAmplitude));
}

pheest pushed a commit to pheest/ADAndor that referenced this issue Feb 10, 2022
MarkRivers added a commit that referenced this issue Feb 10, 2022
Only call SetVSAmplitude if the camera supports it. (Issue #49)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants