Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advertised services no longer publishing after update to 3.22.8.0 #492

Closed
ai6bx opened this issue Aug 29, 2022 · 16 comments
Closed

Advertised services no longer publishing after update to 3.22.8.0 #492

ai6bx opened this issue Aug 29, 2022 · 16 comments

Comments

@ai6bx
Copy link

ai6bx commented Aug 29, 2022

I have been updating nodes and finding that advertised services, switches, phones, cameras, etc., are not showing when viewed under status. Going to DHCP/Forwarding, the links show up with a circle with a question mark in it. When save is clicked and processed, links come back.

@aanon4
Copy link
Contributor

aanon4 commented Aug 29, 2022

Can you provide more information about the services which are not being advertised? Can you verify that the service can be reached (e.g. by entering the expected http://.... address). Please attach the support data for a node with these issues.

Changes in the new release will not publish services which are not actually available.

@ai6bx
Copy link
Author

ai6bx commented Aug 30, 2022 via email

@aanon4
Copy link
Contributor

aanon4 commented Aug 30, 2022

So when you update the ports page, everything is immediately published regardless of whether the system thinks it exists or not. Only later does it check for validity. That's why you see them for a while, and then they disappear.

Do these links immediately resolve to their services, or is there some form of http redirection before that?

Also, can you please attached the support data? Thanks.

@aanon4
Copy link
Contributor

aanon4 commented Aug 30, 2022

So, just looking at one of your nodes. Is this before or after services disappear?

Screen Shot 2022-08-29 at 11 22 00 PM

Are you seeing everything disappear, or are only some disappearing?

@aanon4
Copy link
Contributor

aanon4 commented Sep 9, 2022

Will close this shortly unless there's new info.

@ai6bx
Copy link
Author

ai6bx commented Sep 11, 2022

Trying to upload screen shots here to with support file provided via email
IMG_0357
IMG_0356

@aanon4
Copy link
Contributor

aanon4 commented Sep 11, 2022

Fantastic. Could you also provide the firmware version running on this node?

Nevermind - seems like you're on 1709-e377086

@aanon4
Copy link
Contributor

aanon4 commented Sep 11, 2022

On the three entries indicating failures, when I test them I see the following:

  1. Still investigating
  2. I get 400 - Bad Request - Invalid hostname - so isn't published.
  3. I get a 404 - so isn't published

@aanon4
Copy link
Contributor

aanon4 commented Sep 11, 2022

Update: On (1) the service uses a 307 redirect, which was missing in my code. I will add it and submit for the next nightly. Would be good to get feedback on (2) and (3).

@aanon4
Copy link
Contributor

aanon4 commented Sep 11, 2022

#506

@ab7pa
Copy link
Contributor

ab7pa commented Sep 11, 2022

Just to clarify, is this issue the result of specific non-AREDN hardware returning HTTP codes that we weren't expecting? We expected standard 2XX "success" codes, while some cameras were returning 3XX "redirect" status codes. This PR should allow the "redirect" codes to be interpreted as reachable on the network too. Previous versions of AREDN firmware did not have the intelligence to check these services for validity, so this is definitely an improvement.

@aanon4
Copy link
Contributor

aanon4 commented Sep 11, 2022

It's a very specific failure case. The validator code cannot validate https links because ... well .. ham radio doesnt like encryption .. so we don't and you can't specific https in the services list - only http. But what a lot of devices do is automatically redirect an incoming http request to an https request (self signed usually). We can't validate that (see earlier) so what we do is stop at that point and assume it's okay so long as the process to the https link is valid. That can include 3xx redirects, so when transitioning from http to https via a redirect, I check that the redirect is valid .. and there are more redirect codes these days that I was initially aware of. And I missed a couple.

@ai6bx
Copy link
Author

ai6bx commented Sep 11, 2022 via email

@ai6bx
Copy link
Author

ai6bx commented Sep 11, 2022 via email

@ai6bx
Copy link
Author

ai6bx commented Oct 11, 2022 via email

@aanon4
Copy link
Contributor

aanon4 commented Oct 18, 2022

Please reopen if this is not fixed in the nightly.

@aanon4 aanon4 closed this as completed Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants