-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advertised services no longer publishing after update to 3.22.8.0 #492
Comments
Can you provide more information about the services which are not being advertised? Can you verify that the service can be reached (e.g. by entering the expected http://.... address). Please attach the support data for a node with these issues. Changes in the new release will not publish services which are not actually available. |
Services include clickable links to access network switches, Astrisk PBX, phone portal, mapping software, etc. yes, they are accessible via IP and after I click the save button on the dhcp tab they become accessible and post visitability again. I will have to restart the nodes again to see if it recreates or if it only occurs upon upgrading.
Keith
…Sent from my iPad
On Aug 28, 2022, at 8:41 PM, Tim Wilkinson ***@***.***> wrote:
Can you provide more information about the services which are not being advertised? Can you verify that the service can be reached (e.g. by entering the expected http://.... address). Please attach the support data for a node with these issues.
Changes in the new release will not publish services which are not actually available.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
So when you update the ports page, everything is immediately published regardless of whether the system thinks it exists or not. Only later does it check for validity. That's why you see them for a while, and then they disappear. Do these links immediately resolve to their services, or is there some form of http redirection before that? Also, can you please attached the support data? Thanks. |
Will close this shortly unless there's new info. |
Fantastic. Could you also provide the firmware version running on this node? Nevermind - seems like you're on 1709-e377086 |
On the three entries indicating failures, when I test them I see the following:
|
Update: On (1) the service uses a 307 redirect, which was missing in my code. I will add it and submit for the next nightly. Would be good to get feedback on (2) and (3). |
Just to clarify, is this issue the result of specific non-AREDN hardware returning HTTP codes that we weren't expecting? We expected standard 2XX "success" codes, while some cameras were returning 3XX "redirect" status codes. This PR should allow the "redirect" codes to be interpreted as reachable on the network too. Previous versions of AREDN firmware did not have the intelligence to check these services for validity, so this is definitely an improvement. |
It's a very specific failure case. The validator code cannot validate https links because ... well .. ham radio doesnt like encryption .. so we don't and you can't specific https in the services list - only http. But what a lot of devices do is automatically redirect an incoming http request to an https request (self signed usually). We can't validate that (see earlier) so what we do is stop at that point and assume it's okay so long as the process to the https link is valid. That can include 3xx redirects, so when transitioning from http to https via a redirect, I check that the redirect is valid .. and there are more redirect codes these days that I was initially aware of. And I missed a couple. |
1709-e377086
From: Tim Wilkinson ***@***.***>
Reply-To: aredn/aredn ***@***.***>
Date: Sunday, September 11, 2022 at 12:20 PM
To: aredn/aredn ***@***.***>
Cc: ai6bx ***@***.***>, Author ***@***.***>
Subject: Re: [aredn/aredn] Advertised services no longer publishing after update to 3.22.8.0 (Issue #492)
Fantastic. Could you also provide the firmware version running on this node?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Looking into 2 and 3 now.
From: Tim Wilkinson ***@***.***>
Reply-To: aredn/aredn ***@***.***>
Date: Sunday, September 11, 2022 at 1:06 PM
To: aredn/aredn ***@***.***>
Cc: ai6bx ***@***.***>, Author ***@***.***>
Subject: Re: [aredn/aredn] Advertised services no longer publishing after update to 3.22.8.0 (Issue #492)
Update: On (1) the service uses a 307 redirect, which was missing in my code. I will add it and submit for the next nightly. Would be good to get feedback on (2) and (3).
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I will get you the support file tomorrow. It reoccurs with each boot.
…Sent from my iPad
On Aug 29, 2022, at 8:23 PM, Tim Wilkinson ***@***.***> wrote:
So, just looking at one of your nodes. Is this before or after services disappear?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
Please reopen if this is not fixed in the nightly. |
I have been updating nodes and finding that advertised services, switches, phones, cameras, etc., are not showing when viewed under status. Going to DHCP/Forwarding, the links show up with a circle with a question mark in it. When save is clicked and processed, links come back.
The text was updated successfully, but these errors were encountered: