Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapse QEMU and VMWARE hardware into two basic types #1091

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Collapse QEMU and VMWARE hardware into two basic types #1091

merged 1 commit into from
Feb 5, 2024

Conversation

aanon4
Copy link
Contributor

@aanon4 aanon4 commented Feb 5, 2024

No description provided.

@aanon4 aanon4 mentioned this pull request Feb 5, 2024
Closed
@aanon4 aanon4 added bug Something isn't working new hardware support waiting for feedback Waiting for feedback from issuer labels Feb 5, 2024
Marx1
Marx1 reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@Marx1 Marx1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean, also allows for easy additions if the virtualization world changes.

@aanon4 aanon4 merged commit 62a6959 into aredn:main Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marx1 Marx1 Marx1 left review comments

Assignees
No one assigned
Labels
bug Something isn't working new hardware support waiting for feedback Waiting for feedback from issuer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aanon4 @Marx1