Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x86 to SUPPORTED_DEVICES.md #1092

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Add x86 to SUPPORTED_DEVICES.md #1092

merged 3 commits into from
Feb 5, 2024

Conversation

Marx1
Copy link
Contributor

@Marx1 Marx1 commented Feb 5, 2024

add x86 to supported devices list as a unsupported device - mainly to add clarity on images / tested configs.

Description

Adds clarity/documentation of x86 images and what it's been tested on. Lists images as unsupported.

Relevant Links

aredn/documentation#336
#1089

Screenshots

n/a

Additional context

As a part of a bug I found in #1089 I wanted to make it a bit easier for people to build VMs, as I had some issues. This also helps new supernode owners who are setting up VM for this in datacenters etc.

add x86 to supported devices list as a unsupported device - mainly to add clarity on images / tested configs.
@aanon4
Copy link
Contributor

aanon4 commented Feb 5, 2024

So to keep this table consistent with how the other tables work we'd need to make a few changes:

target should be x86
subtarget should be 64
image should be x86-64-generic-ext4

These are related to how the images are configured and built.

Stability and Status - Proxmox is supported and stable and has been in at least the last two releases. VMWare is in nightly. The support for the rest is unknown to me and I'm not inclined to include them unless someone has at last tested them a bit.

Hypervisor versions - why these version numbers? I run an older version of Proxmox than this. Are these the versions you've tested on?

RAM - 64M is fine minimum.

Virtual type - does this add anything?

The footnote is incorrect. These builds are supported as much as that's indicated in the table.

@Marx1
Copy link
Contributor Author

Marx1 commented Feb 5, 2024

Thanks for the feedback Tim!

I'll update the table, and the related merge request in the documentation.

For the support status, I was going on comments I saw in Slack, and version was ones I've tested. It could be pulled out.

@aanon4
Copy link
Contributor

aanon4 commented Feb 5, 2024

I know they work on Proxmox 7.0 onwards if you want to tweak that version number.

Adjust based on feedback
Comment on lines 154 to 155
Vmware ESXi | x86 | 64 | x86-64-generic-ext4 | 64mb+ | stable | released (5)
Proxmox pve | x86 | 64 | x86-64-generic-ext4 | 64mb+ | stable | nightly (5)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other way round - proxmox is released, vmware is nightly.

@Marx1
Copy link
Contributor Author

Marx1 commented Feb 5, 2024

For stability, I personally run it on Unraid, I've ran both release and nightly for a while with no issues.

@aanon4 aanon4 self-requested a review February 5, 2024 23:37
@aanon4 aanon4 merged commit 4523eb3 into aredn:main Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants