Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show progress bar during reboot/reflash and show estimated time remaining in MM:SS. #1156

Merged
merged 3 commits into from
Apr 7, 2024

Conversation

pmilazzo
Copy link
Contributor

@pmilazzo pmilazzo commented Apr 7, 2024

Description

When rebooting or reflashing the node, display a progress bar as
well as the estimated time remaining. Also, show the time remaining
in MM:SS format.

When rebooting or reflashing the node, display a progress bar as
well as the estimated time remaining. Also show the time remaining
in MM:SS format.
@aanon4
Copy link
Contributor

aanon4 commented Apr 7, 2024

Just confirming you've tested this patch before I commit it? Touching the code around the flash process always makes me a little cautious.

@aanon4
Copy link
Contributor

aanon4 commented Apr 7, 2024

So I had chance to try this on my x86 instance this morning. Only tried the flashing version using Safari. On this, rather than the Wriring Firmware progress bar slowly changing, it does a Night Rider / Cylon impression and moves the bar back and forth. I guess this is a browser compatibility thing.

@pmilazzo
Copy link
Contributor Author

pmilazzo commented Apr 7, 2024

Tim: thanks for testing! I don't have a way to test with Safari, but in other browsers the Cylon effect means that the value attribute of the progress element hasn't been set. I don't initialize value in the original document, so the Cylon effect is expected until the first execution of the cdown() function. The Cylons will now also reappear if the estimated time expires, to suggest that the remaining interval is unknown (and perhaps that you should be relocating your Battlestar ASAP...).

I made a few tweaks I hope will improve browser compatibility; it seems to work with Chrome, Edge, and Firefox.

I have tested flashing both with and without retaining the configuration.

Copy link
Contributor

@aanon4 aanon4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems to have made Safari happy.

@aanon4 aanon4 merged commit 9dafffa into aredn:main Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants