Scan cache #1160
Merged
Scan cache #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change was suggested as a way of handling Ubiquiti AC devices which disconnect while scanning and making retrieving the results problematic if that was your connection. Now we scan and store the results so they can be retrieved later. In fact we no longer scan when navigating to this page but require an explicity scan button push. This make the page generally more responsive when initially navigated to.
|
I wonder if this could be problematic, and not show SSIDs all SSID's. if
the broadcast interval of Wi-Fi SSIDs is missed.
…On Wed, Apr 10, 2024, 2:05 PM Tim Wilkinson ***@***.***> wrote:
Cache the last wifi scan and update it when a re-scan is requested. This
change was suggested as a way of handling Ubiquiti AC devices which
disconnect while scanning and making retrieving the results problematic if
that was your connection. Now we scan and store the results so they can be
retrieved later. In fact we no longer scan when navigating to this page
show the last scan and a time stamp. To update the scan push the rescan
button. This make the page generally more responsive when initially
navigated to.
------------------------------
You can view, comment on, or merge this pull request online at:
#1160
Commit Summary
- 075b0ca
<075b0ca>
Cache the last wifi scan and update it when a re-scan is requested.
- a7bc9f2
<a7bc9f2>
Improve first time message
File Changes
(1 file <https://github.com/aredn/aredn/pull/1160/files>)
- *M* files/www/cgi-bin/scan
<https://github.com/aredn/aredn/pull/1160/files#diff-69c08ff99251868c9ca85db0b7d1e131187fe79d29560df2dc91dc8d9d44885f>
(388)
Patch Links:
- https://github.com/aredn/aredn/pull/1160.patch
- https://github.com/aredn/aredn/pull/1160.diff
—
Reply to this email directly, view it on GitHub
<#1160>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEW6LBJXY5FTUIKCILQ7ELY4WSQHAVCNFSM6AAAAABGBEPJOCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZTMNBSGU2TENY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
@mathisono Can you explain more? This change doesnt effect how the scan actually works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache the last wifi scan and update it when a re-scan is requested. This change was suggested as a way of handling Ubiquiti AC devices which disconnect while scanning and making retrieving the results problematic if that was your connection. Now we scan and store the results so they can be retrieved later. In fact we no longer scan when navigating to this page show the last scan and a time stamp. To update the scan push the rescan button. This make the page generally more responsive when initially navigated to.