Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve unresponsive node problems with Mikrotik AC devices. 04/01/2023 #776

Merged
merged 2 commits into from
Apr 2, 2023

Conversation

aanon4
Copy link
Contributor

@aanon4 aanon4 commented Apr 1, 2023

Mikrotik AC devices get into a state where they wont communicate with non-AC devices .. sometimes. Leaving and rejoining the network resets everything. We monitor for this situation and rejoin the network when detected to resolve the issue.

Diagnosis:

It looks like somewhere in the Mikrotik AC firmware, devices broadcast their beacons with an incorrect channel width. This will then confuse devices connecting to them resulting in failed communications. The situation is very intermittent and not all devices seem to be effected, and not every time even if they are.

I'm trying to detect the issue using the arping process as before. This is imperfect as devices sometimes dont answer (wifi broadcasts are unreliable) so I'm looking for failures over time before leaving and rejoining the IBSS network. This means detection and correct can take a few minutes. I'm trying to head the problem off for Mikrotk AC devices by doing a rejoin early on regardless.

Mikrotik AC devices get into a state where they wont communicate with
non-AC devices .. sometimes. Leaving and rejoinging the network resets
everything. We monitor for this situation and rejoin the network when detected
to resolve the issue.
@ae6xe
Copy link
Contributor

ae6xe commented Apr 1, 2023

in ath9k, only clock changes were made to do 5 and 10 MHz channels. Everything else always reported and still thought only a 20MHz bandwidth was occurring. Upstream changes were never made in iw, wifi, and more to account for channel widths beyond the 802.11 specification. ath10k should be the same in this regard.

I'm not 100%, but I think the spec and the beacons are always in a 20MHz channel, with the 40, 80, ... being multiple blocks of the 20MHz channel. Although, the beacon should only report these blocks, even in 5 and 10MHz channel widths; HT20, HT40- (block below), HT40+(block above), ...
HT capabilities:
Capabilities: 0x1ad
RX LDPC
HT20
SM Power Save disabled
RX HT20 SGI
TX STBC
RX STBC 1-stream
Max AMSDU length: 3839 bytes
No DSSS/CCK HT40
Maximum RX AMPDU length 65535 bytes (exponent: 0x003)
Minimum RX AMPDU time spacing: 4 usec (0x05)
HT RX MCS rate indexes supported: 0-31
HT TX MCS rate indexes are undefined
HT operation:
* primary channel: 11
* secondary channel offset: no secondary
* STA channel width: 20 MHz

All this to the question... What is found other than "STA channel width: 20 MHz" in beacons?

For sure, let's commit this PR to gain more insight.

@aanon4
Copy link
Contributor Author

aanon4 commented Apr 1, 2023

It's more about what the beacon payloads say about how to use the channel. On the receiver end the beacon information sometimes doesnt match what is expected when sent from a Mikrotik AC device. You'll see failed kernel assertions at times about this. It would be good to understand more about what's actually happening because - well - Ubiquiti doesnt do it.

@aanon4
Copy link
Contributor Author

aanon4 commented Apr 1, 2023

It does solve the problem in the couple of places I can test it (one my test bench, the other up on a hill near Livermore). Would be good to get some more testing in and I have another couple of people available to try it.

@aanon4 aanon4 requested review from dman776 and ae6xe April 1, 2023 19:50
Copy link
Contributor

@ae6xe ae6xe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ae6xe ae6xe merged commit 211006b into aredn:main Apr 2, 2023
@ae6xe ae6xe changed the title Resolve unresponsive node problems with Mikrotik AC devices. Resolve unresponsive node problems with Mikrotik AC devices. 04/01/2023 Apr 2, 2023
@aanon4
Copy link
Contributor Author

aanon4 commented Apr 3, 2023

Reports from various testers say this fixed the problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants