Remove hardwired frequency tables and use information from the hardware #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the major change to radios.json going to impact the /www/cgi-bin/status display which gets the model name from that file? Line 453: (aredn.hardware.get_radio() or { name = "unknown" }).name |
|
No, that's taken care of. If you provide a name, that will be used; if not, the key will be used as the name (the library handles this). |
|
Anything in sysinfo.json or api affected by this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something @ae6xe had mentioned before the last release, but it touched on too many things to include then.
The goal here is to remove the various hardwired tables we have when determining what frequencies a devices can use, and instead read them from the hardware. This is a step towards us being able to use different radios for different things as it remove some assumptions about what radio must be used for what.
I've not been able to test this on a 900MHz device (I dont have one).