Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frequency range reporting and display for 900MHz & 3GHz devices #803

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

aanon4
Copy link
Contributor

@aanon4 aanon4 commented Apr 24, 2023

Thanks to @pmilazzo for helping debug this.

@aanon4 aanon4 requested review from dman776 and ae6xe April 24, 2023 00:53
@dman776 dman776 merged commit be969b1 into aredn:main Apr 24, 2023
@k6ccc
Copy link

k6ccc commented Apr 25, 2023

What's supposed to be different on this one? I updated all three of my Rocket M3 nodes to NB 2588 and don't see any difference. Or did this only affect 900 MHz devices despite the name?

Also, reminder to please add the release date on releases so the date shows up on the change log. Really makes it easier to tell what is new when there are lots of changes happening.

@pmilazzo
Copy link
Contributor

pmilazzo commented Apr 25, 2023

Jim:

The PR changes two things: the "Channel" value displayed on the Node Status page (the node's home page) and the values in the "Channel" selector box on the Basic Setup tab. Both should now contain only the frequency in MHz and not the (misleading) channel number.

Also, the previous nightly build would allow you to choose inappropriate (out of band) frequencies; it is now limited to appropriate choices.

I have not been able to test this version on my M3 nodes because we are currently experiencing a network partition and all my M3 nodes are in the other half. Thus, it would be helpful if you could verify that your displayed frequencies are correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants