Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure, modularize and tidy the navigation buttons and menus #805

Merged
merged 9 commits into from
Apr 26, 2023

Conversation

aanon4
Copy link
Contributor

@aanon4 aanon4 commented Apr 25, 2023

This change restructures the menu system to make it more modular and more flexible with the goal to achieving a few things:

  1. Provide general html navigation generator methods for both the user buttons and admin menus.
  2. Allow menus to be disabled and hidden.
    a. This is used to disable the tunnel menus on tiny platforms which no longer ship with the vtund installed (due to space limitations).
    b. On Mikrotik devices, disable all the unusable buttons while running from RAM.
  3. Improve messaging when installing from RAM disk to get people to the right place.
  4. Fixup a bunch of visual alignment issues where menus would jump around slightly on the screen depending which page they were on.
  5. Fix the Bad Gateway issues when the radio is not recognized.

@dman776
Copy link
Contributor

dman776 commented Apr 25, 2023

I like it. Is /www/cgi-bin/nav/* the proper place for these? Or, should it be in /usr/lib/lua/aredn/nav/*

@aanon4
Copy link
Contributor Author

aanon4 commented Apr 25, 2023

@dman776 I wasnt sure where to put the nav and your place is better - I'll move it.

@ae6xe
Copy link
Contributor

ae6xe commented Apr 25, 2023

ditto, great work!

@aanon4
Copy link
Contributor Author

aanon4 commented Apr 25, 2023

Menus moved!

@aanon4 aanon4 merged commit deeacc2 into aredn:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants