Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced networking tab #834

Merged
merged 3 commits into from
May 17, 2023
Merged

Advanced networking tab #834

merged 3 commits into from
May 17, 2023

Conversation

aanon4
Copy link
Contributor

@aanon4 aanon4 commented May 11, 2023

Proposing a new "Advanced Network" tab on supported devices (although I'm aware this is adding complexity). This provide UI access to features already available by editing configuration files. Two features are surfaced:

  1. The ability to reassign the default purpose of the standard ports on supported multi-port devices.
  2. The ability to create xlinks (vlans which act like vlan2) which we're using for wiring up backbone links in AREDN networks.

These features are currently supported by installing a seperate package, and we can continue to do that if people prefer, but I thought it might be a more generally useful feature to expose.

Visually, it looks like this:

Screenshot 2023-05-10 at 5 43 09 PM

Currently supported on the hAP ac2 and hAP ac3.

@aanon4 aanon4 requested review from dman776, ae6xe, wu2s, K6AH and ab7pa May 11, 2023 00:53
Copy link
Contributor

@dman776 dman776 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the concept. Is a top-level menu the correct place for this? Or should it be under Advanced Config somewhere?

@aanon4
Copy link
Contributor Author

aanon4 commented May 11, 2023

We dont really have any other good UI spots for it. We have the "user" stuff (e.g. status page + other pages which dont require the admin password), the admin stuff (where I stuck this) and the advanced options page which is just a list of properties. You cant really put this UI there, and we dont have any call outs to new pages from that page - it wouldnt fit with the way that all works. So ... it ended up here as the best option.

@dman776 dman776 merged commit f9b032a into aredn:main May 17, 2023
@k1ky
Copy link

k1ky commented May 23, 2023

I believe this would satisfy my feature request #19?

@aanon4
Copy link
Contributor Author

aanon4 commented May 23, 2023

@k1ky This is only for devices which support the new Distributed Switch Architecture (DSA) in OpenWRT I'm afraid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants