Support switching mesh radio on multi-radio devices #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab7pa
suggested changes
May 24, 2023
files/usr/local/bin/node-setup
Outdated
| @@ -170,7 +170,9 @@ do | |||
| end | |||
|
|
|||
| if cfg.wifi_enable == "1" then | |||
| cfg.wifi_intf = aredn.hardware.get_board_network_ifname("wifi"):match("^(%S+)") | |||
| if not cfg.wifi_intf or cfg.wifi_intf = "" then | |||
There was a problem hiding this comment.
There is a missing "=" in the if statement on line 173.
Should be if not cfg.wifi_intf or cfg.wifi_intf == "" then
Once that is added, the rest of the feature works as designed.
|
Also, for some reason the new Mesh RF link is not showing up on the Neighbor Status page |
|
@ab7pa Nice catch, thanks. Fix it. |
|
@ab7pa Thanks - looks like there are a few more places I need to review for where the default mesh radio is hard coded. I'll keep this in draft until I'm done with that. |
|
BTW did I mention that this is an AWESOME FEATURE! :) |
|
Okay, backup for review after a few fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.